Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44196/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44196/8//COMMIT_MSG@16
PS8, Line 16: Updating spi driver Kconfig to set
: BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY=y if both
: BOOT_DEVICE_SPI_FLASH_RW_NOMMAP=y and BOOT_DEVICE_SPI_FLASH=y to bring
: the appropriate libraries into romstage.
Or, alternatively, how about flipping NOMMAP_EARLY around into BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES?
+1. That makes sense. I think most future platforms would be okay with writes in early stages and so having that as default makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3430bda45484cb8c2b01ab9614508039dfaac9a3
Gerrit-Change-Number: 44196
Gerrit-PatchSet: 22
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Sep 2020 17:24:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment