Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84894?usp=email )
Change subject: mb/google/nissa/var/glassway: Add touch screen ILIT2901 support ......................................................................
mb/google/nissa/var/glassway: Add touch screen ILIT2901 support
1. Extend 1 bit [34] for the TOUCHSCREEN_SOURCE. SSFC range for TOUCHSCREEN_SOURCE is bit[32:34]. 2. Touchscreen panel: MUTTO A153728S1Y, and set TOUCHSCREEN_ILIT2901 to value "4" 3. Datasheet: #153728S1V1.0 SPEC_20240923.pdf
BUG=b:375986645 BRANCH=firmware-nissa-15217.B TEST=1. emerge-nissa coreboot chromeos-bootimage 2. Confirm command evtest and touchscreen function is workable.
Change-Id: I6e13c948edca5a894e1a00a1954f0f88c4a079cf Signed-off-by: Daniel Peng Daniel_Peng@pegatron.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84894 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Jayvik Desai jayvik@google.com Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/glassway/overridetree.cb 1 file changed, 18 insertions(+), 1 deletion(-)
Approvals: Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved Jayvik Desai: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brya/variants/glassway/overridetree.cb b/src/mainboard/google/brya/variants/glassway/overridetree.cb index 3e2e2f1..85c08db 100644 --- a/src/mainboard/google/brya/variants/glassway/overridetree.cb +++ b/src/mainboard/google/brya/variants/glassway/overridetree.cb @@ -31,11 +31,12 @@ option WFC_ABSENT 0 option WFC_PRESENT 1 end - field TOUCHSCREEN_SOURCE 32 33 + field TOUCHSCREEN_SOURCE 32 34 option TOUCHSCREEN_UNPROVISIONED 0 option TOUCHSCREEN_ELAN0001 1 option TOUCHSCREEN_GTCH7503 2 option TOUCHSCREEN_ELAN9004 3 + option TOUCHSCREEN_ILIT2901 4 end end
@@ -394,6 +395,22 @@ probe TOUCHSCREEN_SOURCE TOUCHSCREEN_ELAN9004 end end + chip drivers/i2c/hid + register "generic.hid" = ""ILIT2901"" + register "generic.desc" = ""ILI Touchscreen"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" + register "generic.detect" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" + register "generic.reset_delay_ms" = "100" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" + register "generic.enable_delay_ms" = "6" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 41 on + probe TOUCHSCREEN_SOURCE TOUCHSCREEN_ILIT2901 + end + end chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_F13)"