build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40525 )
Change subject: soc/mediatek/mt8183: High frequency should use range 1 [DRAFT] [DONOT MERGE] ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... PS2, Line 227: dramc_dbg("write leveling[%d][%d][%d] = 0x%x\n", chn0, rk,dqs, wr_level[chn0][rk][dqs]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... PS2, Line 227: dramc_dbg("write leveling[%d][%d][%d] = 0x%x\n", chn0, rk,dqs, wr_level[chn0][rk][dqs]); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... PS2, Line 1843: vref_begin = params->tx_vref[chn][rank] | (vref_range << 6) ; space prohibited before semicolon