Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: Load calibration params and run DRAM calibration flow
......................................................................
Patch Set 30:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35110/30/src/mainboard/google/kukui...
File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/30/src/mainboard/google/kukui...
PS30, Line 44: CALIBRATION_REGION
Please add an assert for this.
# the section defined in chromeos.fmd is only 0x2000 bytes.
assert(length < 0x2000);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35110
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8de29b14b1fb24b3b4f351c855c5c4d8f350cc34
Gerrit-Change-Number: 35110
Gerrit-PatchSet: 30
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 09:35:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment