Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34535 )
Change subject: lib: Call extract() only when initrd.size is more than 0 ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG@9 PS2, Line 9: avoid avoids
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG@11 PS2, Line 11: don't know extract Do you mean: don’t know how to?
https://review.coreboot.org/c/coreboot/+/34535/2//COMMIT_MSG@15 PS2, Line 15: Change-Id: I85aa33d2c2846b6b3a58df834dda18c47433257d Please switch the lines, so the Signed-off-by line is at the end.
https://review.coreboot.org/c/coreboot/+/34535/2/src/lib/fit_payload.c File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/34535/2/src/lib/fit_payload.c@249 PS2, Line 249: initrd.size > 0 Please make that a separate check, so that you can print out a warning in this case. If `config->ramdisk` is true, then it is likely a user error, and a warning should be shown.