[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add northbridge pci driver

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )

Change subject: soc/amd/picasso: Add northbridge pci driver
......................................................................

Patch Set 30:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34424/15/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/15/src/soc/amd/picasso/northb... 
PS15, Line 144: .read_resources	  = read_resources,
> Oops, missed considering this one before repushing.

I guess we could move it. Let's keep it like this for now. We can move it later if required.

https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... 
PS28, Line 70: TOM1
> Yeah, nothing in coreboot seems to be using it as well. There is an External (TOM2) in pci0. […]

Removed it.