[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Raul Rangel (Code Review)]

Attention is currently required from: Patrick Rudolph.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 27:

(1 comment)

File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/comment/1b0ef143_f01be4ac 
PS27, Line 53: 		       " This is a driver bug.\n", __func__, fb->bits_per_pixel, bpp_mask);
I broke down and looked at the spec, and think I understand 😊
> The RedMaskSize, GreenMaskSize, BlueMaskSize, and RsvdMaskSize fields define the size, in bits, of the red, green, and blue components of a direct color pixel. A bit mask can be constructed from the MaskSize fields using simple shift arithmetic. For example, the MaskSize values for a Direct Color 5:6:5 mode would be 5, 6, 5, and 0, for the red, green, blue, and reserved fields, respectively. Note that in the YUV MemoryModel, the red field is used for V, the green field is used for Y, and the blue field is used for U. The MaskSize fields should be set to 0 in modes using a memory model that does not have pixels with component fields.

I have filed a bug with AMD to get the VBIOS fixed. I like your last suggestion. I can send a CL with that change.