[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8189: Add usb host support

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Liu Liu, Paul Menzel, Vince Liu, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87021?usp=email )

Change subject: soc/mediatek/mt8189: Add usb host support
......................................................................

Patch Set 1:

(1 comment)

File src/soc/mediatek/mt8189/include/soc/usb.h:

https://review.coreboot.org/c/coreboot/+/87021/comment/312d406e_68289a6f?usp... :
PS1, Line 22: check_member(ssusb_sif_port, u3phyd, 0x600);
            : check_member(ssusb_sif_port, u3phya, 0x800);
            : check_member(ssusb_sif_port, u3phya_da, 0x900);
            : check_member(ssusb_sif_port, reserved2, 0xa00);
> Should macros be defined for the values?

Those are offset value. I don't think it makes sense to define those values.