26 Feb
2019
26 Feb
'19
11:16 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31516/2/src/mainboard/google/kukui/Kconfig File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/#/c/31516/2/src/mainboard/google/kukui/Kconfig@6... PS2, Line 68: config SSPM_BIN_FILE
Why is this a Kconfig? This should just be a well-known name (e.g. […]
@Julius I requested this to be a Kconfig, in case if we need to create build target-specific SSPM files in future, or even devices that do not have SSPM image files. What do you think?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31516
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ae6034454326f5115cd3948819adc448b67fb1c
Gerrit-Change-Number: 31516
Gerrit-PatchSet: 2
Gerrit-Owner: Erin Lo erin.lo@mediatek.com
Gerrit-Reviewer: Chun-ta Lin itspeter@google.com
Gerrit-Reviewer: Erin Lo erin.lo@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Comment-Date: Tue, 26 Feb 2019 10:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment