huayang duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32243 )
Change subject: mediatek/mt8183: add SAMSUNG and MICRON EMCP LPDDR4X support
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32243/3/src/soc/mediatek/mt8183/dramc_pi_cal...
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/#/c/32243/3/src/soc/mediatek/mt8183/dramc_pi_cal...
PS3, Line 35: -16
why is this changed, and will this be a problem for other existing DRAM modules? […]
From the calibration log of EMCP-SAMSUNG DDR, we found the begin pass range of RX window early than other DDR. Because the pass window will be affected by SOC chip manufacturing process, DDR chip manufacturing process, current volatge, temperature and some other environment. If we not increase the begin scan range, the pass window maybe get wrong result at some board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32243
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fcc8673a2fbd7ec3a8776ab61c57f8903ddda20
Gerrit-Change-Number: 32243
Gerrit-PatchSet: 3
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 12 Apr 2019 02:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment