Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36140 )
Change subject: [POC,RFC] Pass cbmem_top from romstage to relocatable stages param
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36140/2/src/arch/x86/postcar_loader...
File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/36140/2/src/arch/x86/postcar_loader...
PS2, Line 152: stack_push(pcf, pcf->num_var_mtrrs);
: stack_push(pcf, pcf->max_var_mtrrs);
: }
:
: struct postcar_param {
: uintptr_t stack_top_ptr;
: uintptr_t cbmem_top_ptr;
: };
:
: static void finalize_load(struct postcar_param *param, uintptr_t stack_top)
: {
: param->stack_top_ptr = stack_top;
: param->cbmem_top_ptr = (uintptr_t)cbmem_top();
isn't this mixing up two different approaches?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3195560f110720959fd7389b366d001bfde4da05
Gerrit-Change-Number: 36140
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 20 Oct 2019 06:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment