Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38293 )
Change subject: coreinfo: Add support for link time optimization ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:
https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 61: default n
I’d default to yes, as less size is more important for firmware purposes.
For now I think no is a safe default - it can enabled in a custom config if the space is really needed.
https://review.coreboot.org/c/coreboot/+/38293/2/payloads/coreinfo/Kconfig@6... PS2, Line 65:
Please mention, if libpayload is then also indirectly built with LTO.
No, this will only change it for coreinfo, libpayload needs to be enabled separately.
https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig File payloads/coreinfo/Kconfig:
https://review.coreboot.org/c/coreboot/+/38293/3/payloads/coreinfo/Kconfig@6... PS3, Line 60: bool "Use link time optimization"
Isn't it experimental?
I tested this in QEMU and hardware, so it should be reasonably safe (it's also turned off by default, so anyone who feels like the extra risk can enable it themselves).