Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35643 )
Change subject: util/intelp2m: add Intel Pad to Macro util ......................................................................
Patch Set 11:
Hi everyone and thank you for the comments.
This would imply rewriting this tool in C. I don't think it's too complex, but it's work that would need to be done.
I wanted to create a project with cool and understandable Go-style architecture to make it easier adding new chipsets such as Sunrise PCH. In addition, it is much more convenient for me to use the generator as a separate utility, since I have many inteltool.log files (including those that were made a long time ago) for analyzing pads.
Maybe this would fit better inside autoport? It happens to be written in Go already, so rewriting would not be needed.
I think it's time to update the file tree and split the code into packages before we start to add many new features (including intelp2m)
main.go/root.go | +-- ec -- lenovo | +-- gpio -- | +-- devtree -- .. | +-- arch --+-- ivysnd | +-- kblskl | +-- apollo
something like that
However, I won't return to autoport soon. Sorry, but I need to do other work :) With this patch, I am finishing work related to gpio macros for the Sunrise chipset.
I could add exec.Command("../intelp2m/intelp2m") to autoport, but I think this is not a good idea