Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39479 )
Change subject: src/soc/tigerlake_dev: Update PMC IPC Hardware ID ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39479/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pmc.asl:
https://review.coreboot.org/c/coreboot/+/39479/2/src/soc/intel/tigerlake/acp... PS2, Line 23: Tiger Lake Is this Tiger Lake specific device? I believe _HID INTC1026 refers to PMC IPC Controller for any Intel platform? If not right now, I think we should think if this should end up in common code like: https://review.coreboot.org/c/coreboot/+/39370
https://review.coreboot.org/c/coreboot/+/39479/2/src/soc/intel/tigerlake/acp... PS2, Line 29: 0x00010000 PCH_PWRM_BASE_SIZE