Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46509 )
Change subject: mrc_cache: Add config MRC_SAVE_HASH_IN_TPM
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46509/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46509/2//COMMIT_MSG@13
PS2, Line 13:
Well, technically there are a couple (e.g. Lenovo t530) which do. […]
t530 is INTEL_SANDYBRIDGE which doesn't really use FSP2.0.
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf...
File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf...
PS2, Line 55: n
Why not just make this default y? I think we'll probably want this on all future devices.
Probably do it only if CHROMEOS is selected? I don't think we want to change the default for any non-Chrome OS FSP2.0 platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5ffcdba27cb1f09c39c3835029c8d9cc3453af1
Gerrit-Change-Number: 46509
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 22:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment