Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48464 )
Change subject: cpu/amd/car: Remove C source incldue of disable_cache_as_ram.c ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48464/3/src/cpu/amd/car/disable_cac... File src/cpu/amd/car/disable_cache_as_ram.c:
https://review.coreboot.org/c/coreboot/+/48464/3/src/cpu/amd/car/disable_cac... PS3, Line 31: static __always_inline
I would guess the always_inline here is not accidental, but I did not trace this to its origins. […]
You are mostly right and I am aware of the amount of work needed. Wanted to get rid of most C includes as possible. As you have said, these are little fixups and didn't cost me that much. If needed I will abandon it and address whole CAR when migrating to POSTCAR_STAGE