Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )
Change subject: soc/intel/tigerlake: Update ACPI files
......................................................................
Patch Set 23:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37781/23/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/camera_clock_ctl.asl:
https://review.coreboot.org/c/coreboot/+/37781/23/src/soc/intel/tigerlake/ac...
PS23, Line 133: CLKF (Arg0, Arg2)
: CLKC (Arg0, Arg1)
This order is now correct for enabling, but for disabling, shouldn't this disable the clock first?
Even for disabling case, this order will work as last step is disable clock and setting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37781
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82156830273c2937f5f02713ed7dd27da41c857
Gerrit-Change-Number: 37781
Gerrit-PatchSet: 23
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Fri, 17 Jan 2020 21:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment