Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30119 )
Change subject: arch/x86/mmu: Port armv8 MMU to x86_64 ......................................................................
Patch Set 9:
Can you consolidate this with: src/cpu/x86/pae/pgtbl.c ?
I didn't touch pae/pgtbl.c for the following reasons:
* arch/x86/mmu.c generates long mode page tables, while pgtbl.c operates on 32bit/PAE page tables * arch/x86/mmu.c generates dynamic page tables, while pgtbl.c has static tables read from cbfs * arch/x86/mmu.c is intended for RAM environments, while pgtbl.c is for PRERAM environments * arch/x86/mmu.c is designed like the other arch/*/mmu.c
I'm going to update the commit message.