[coreboot-gerrit] Change in ...coreboot[master]: Makefile.inc: Add macro to link a file in all stages

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33198 )

Change subject: Makefile.inc: Add macro to link a file in all stages
......................................................................

Patch Set 6:
> Patch Set 6: Code-Review+1
>
> Looks good, just the order of the parameters feels wrong.
> Maybe that's just me, but... currently the condition comes
> first:
> somestage-$(CONFIG_SOMETHING) += somefile.c
>
> Keeping that order would also help to emphasize the file
> name, I think. Maybe we could even make that more literal,
> e.g. `all_stages_if`:
> $(call all_stages_if,$(CONFIG_SOMETHING),somefile.c)

I agree with reversing the arguments.  I think that makes it more readable.