[coreboot-gerrit] [L] Change in coreboot[main]: mb/asrock: Add Z87 Extreme4 (Haswell)

[Angel Pons (Code Review)]

Attention is currently required from: Jan Philipp Groß, Keith Hui, Máté Kukri, Nicholas Chin.

Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/84672?usp=email )

Change subject: mb/asrock: Add Z87 Extreme4 (Haswell)
......................................................................

Patch Set 11: Code-Review+2

(1 comment)

File src/mainboard/asrock/z87_extreme4/mainboard.c:

https://review.coreboot.org/c/coreboot/+/84672/comment/c388c417_ddbd2d4a?usp... :
PS11, Line 16: /* Enable configuration: pass entry key '0x87' into index port dev
             :  * two times. */
             : void nuvoton_pnp_enter_conf_state(pnp_devfn_t dev)
             : {
             : 	u16 port = dev >> 8;
             : 	outb(NUVOTON_ENTRY_KEY, port);
             : 	outb(NUVOTON_ENTRY_KEY, port);
             : }
             : 
             : /* Disable configuration: pass exit key '0xAA' into index port dev. */
             : void nuvoton_pnp_exit_conf_state(pnp_devfn_t dev)
             : {
             : 	u16 port = dev >> 8;
             : 	outb(NUVOTON_EXIT_KEY, port);
             : }
This is a workaround for these functions being defined in `early_serial.c` for early stages only. I'll make a follow-up addressing this.