Weiyi Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45402 )
Change subject: soc/mediatek: Add function to get clock frequency of MT8192 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45402/1/src/soc/mediatek/mt8192/pll... File src/soc/mediatek/mt8192/pll.c:
https://review.coreboot.org/c/coreboot/+/45402/1/src/soc/mediatek/mt8192/pll... PS1, Line 495: CLK26CALI_1_LOAD_CNT
align to previous (
Done
https://review.coreboot.org/c/coreboot/+/45402/1/src/soc/mediatek/mt8192/pll... PS1, Line 498: 0x10
give this a name (especially we'll reuse it below)?
Done
https://review.coreboot.org/c/coreboot/+/45402/1/src/soc/mediatek/mt8192/pll... PS1, Line 502: udelay(10);
Is udelay(10) needed? can we use stopwatch?
Done