[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/xeon_sp: Use fixed BDF for IBL

[Jérémy Compostella (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, TangYiwei, Tim Chu.

Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81321?usp=email )

Change subject: soc/intel/xeon_sp: Use fixed BDF for IBL
......................................................................

Patch Set 8:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81321/comment/fa4cd0f9_ab479570 :
PS8, Line 8: 
In general, I am in favor of using the full name of an acronym the first time it is being used in documentation and I consider that commit message should be documentation level quality.

This is not mandatory as I don't know how other feel about that but here are my replacement suggestions.

https://review.coreboot.org/c/coreboot/+/81321/comment/46000685_820685ba :
PS8, Line 9: IBL codes doesn't support bootloader controlled P2SB hidden and
s/IBL/Intermediate Bootloader (IBL)/

https://review.coreboot.org/c/coreboot/+/81321/comment/158cc0bb_d5d208b9 :
PS8, Line 10: unhidden. Hence, dyanmically read IBL HPET/IOAPIC BDF by
s/BDF/Bus:Device.Function (BDF)/

https://review.coreboot.org/c/coreboot/+/81321/comment/9d378f30_6d135232 :
PS8, Line 11: bootloader is not supported, because when P2SB is hidden the
s/P2SB/Primary-to-Sideband Bridge (P2SB)/

File src/soc/intel/xeon_sp/util.c:

https://review.coreboot.org/c/coreboot/+/81321/comment/7bf5df31_3dbee042 :
PS8, Line 95: 	if (CONFIG(SOC_INTEL_COMMON_IBL_BASE)) {
line length limit in coreboot is 96 characters. I don't know why checkpatch did not catch that. Regardless I think the following version is more readable anyway. What do you think ?

```
    	union p2sb_bdf bdf = {
    		.bus = HPET_BUS_NUM,
    		.dev = HPET_DEV_NUM,
    		.fn = HPET0_FUNC_NUM
    	};
```

https://review.coreboot.org/c/coreboot/+/81321/comment/57ea2b3d_23471b79 :
PS8, Line 105: 		union p2sb_bdf bdf = {.bus = PCH_IOAPIC_BUS_NUMBER, .dev = PCH_IOAPIC_DEV_NUM, .fn = PCH_IOAPIC_FUNC_NUM};
same here.