build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: [WIP] ssdtgen for PNP devices ......................................................................
Patch Set 6:
(9 comments)
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c File src/superio/common/ssdt.c:
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@36 PS6, Line 36: {"PNP0700", {0x3f0, 0x3f2, 0x3f7}, {6, }}, space required after that close brace '}'
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@37 PS6, Line 37: {"PNP0303", {60, 64, }, {1, }}, space required after that close brace '}'
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@38 PS6, Line 38: {"PNP0F03", {60, 64, }, {12, }}, space required after that close brace '}'
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@39 PS6, Line 39: {"PNP0501", {0x3f8, 0x2f8, 0x3e8, 0x2e8}, {4, 3}}, space required after that close brace '}'
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@40 PS6, Line 40: {"PNP0400", {0x378, }, {7, }}, space required after that close brace '}'
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@54 PS6, Line 54: printk(BIOS_ERR, "%s: Missing ACPI path/scope\n", dev_path(dev)); line over 80 characters
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@111 PS6, Line 111: FIELDLIST_OFFSET (0x74), space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@139 PS6, Line 139: FIELD_BYTEACC | FIELD_NOLOCK | FIELD_PRESERVE); line over 80 characters
https://review.coreboot.org/#/c/33033/6/src/superio/common/ssdt.c@266 PS6, Line 266: printk(BIOS_ERR, "%s: Missing ACPI path/scope\n", dev_path(dev)); line over 80 characters