Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86135?usp=email )
Change subject: mb/starlabs/byte_adl: Change HPD GPIO to DEEP reset ......................................................................
mb/starlabs/byte_adl: Change HPD GPIO to DEEP reset
This is proven to be more reliable when resuming from S3.
Change-Id: I479493a384ae1ca880a0caf255ea832b4bb9a366 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86135 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 5e9ca3f..4a6f38e 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -75,7 +75,7 @@ /* A18: DDI B DP HPD */ PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* A19: TCP0 HPD */ - PAD_CFG_NF(GPP_A19, NONE, PLTRST, NF1), + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* A20: Test Point 2 */ PAD_NC(GPP_A20, NONE), /* A21: Fingerprint Reader Interrupt */