12 Mar
2021
12 Mar
'21
5:37 p.m.
Attention is currently required from: Raul Rangel, EricR Lai. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51240 )
Change subject: mb/google/guybrush: Add ACPI support for Chrome EC ......................................................................
Patch Set 19:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/51240/comment/fdd18b57_3db505e3 PS19, Line 61: EC_ENABLE_WAKE_PIN GEVENT_3
Nit: Something to consider for a future patch, what if the GPIOs move on one of the variants. […]
Sounds like a good thing to keep in mind.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51240
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb8aba87390475cad7a2a9911c3832a59c987b65
Gerrit-Change-Number: 51240
Gerrit-PatchSet: 19
Gerrit-Owner: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 13 Mar 2021 01:37:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment