build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36657 )
Change subject: lib/fmap: Add optional pre-RAM cache ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36657/1/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/c/coreboot/+/36657/1/src/include/memlayout.h@79 PS1, Line 79: #define FMAP_CACHE(addr, sz) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/36657/1/src/include/memlayout.h@79 PS1, Line 79: #define FMAP_CACHE(addr, sz) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/36657/1/src/include/memlayout.h@82 PS1, Line 82: STR(FMAP does not fit in FMAP_CACHE! (sz < FMAP_SIZE))); space required before that '!' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/36657/1/src/include/memlayout.h@82 PS1, Line 82: STR(FMAP does not fit in FMAP_CACHE! (sz < FMAP_SIZE))); space prohibited after that '!' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/36657/1/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/36657/1/src/lib/fmap.c@35 PS1, Line 35: #define print_once(...) if (!car_get_var(fmap_print_once)) printk(__VA_ARGS__) Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects