Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/mrc_cac... File src/security/vboot/mrc_cache_hash_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/mrc_cac... PS10, Line 27: /* We do not store normal mode data hash in TPM. */ : if (!vboot_recovery_mode_enabled()) : return;
It is not correct to drop this. […]
Moved to https://review.coreboot.org/c/coreboot/+/46511
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/secdata... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/secdata... PS10, Line 171: } else {
That would have to be done where you actually introduce the index. […]
Done