Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33782 )
Change subject: vbe.h: Make use of __packed attribute in vbe_info_t structure
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33782/7/src/include/vbe.h
File src/include/vbe.h:
https://review.coreboot.org/c/coreboot/+/33782/7/src/include/vbe.h@42
PS7, Line 42: u8 *oem_string_ptr;
unaligned
https://review.coreboot.org/c/coreboot/+/33782/7/src/include/vbe.h@43
PS7, Line 43: u32 capabilities;
unaligned
https://review.coreboot.org/c/coreboot/+/33782/7/src/include/vbe.h@47
PS7, Line 47: } __packed vbe_info_t;
This makes some fields unaligned which is a pain to review. And I can't
find any code in the follow-up commits that requires this. Please ela-
borate.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e79b21acf44f6ca184a09d42acdf69c31dd4841
Gerrit-Change-Number: 33782
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 07 Jul 2019 12:15:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment