Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add Family 15h
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34561/11/Documentation/soc/amd/fami...
File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/11/Documentation/soc/amd/fami...
PS11, Line 22: comprises 3-chip solutions, 2, and single-chip
"Fam 15h setups use up to three separate chips"? The "3-chip", "2", "single" stuff looks very inconsistent.
https://review.coreboot.org/c/coreboot/+/34561/11/Documentation/soc/amd/fami...
PS11, Line 34: technology
It's code ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaab4edc431329a691283121494595f3797c566c6
Gerrit-Change-Number: 34561
Gerrit-PatchSet: 11
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Kerry Brown
kerry.brown@silverbackltd.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Thu, 26 Sep 2019 15:16:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment