Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31245 )
Change subject: soc/intel/{skylake,cannonlake,icelake}: Correct GPIO IRQ start map
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31245/1/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/itss.h:
https://review.coreboot.org/#/c/31245/1/src/soc/intel/cannonlake/include/soc...
PS1, Line 19: 24
restoring of polarities already takes care of updating only the right bits based on start offset.
Sounds like there needs to be come comments put down explaining the implicit assumptions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c12e6ca01453da92259f077771c3f4d887aa03d
Gerrit-Change-Number: 31245
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Feb 2019 20:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment