Attention is currently required from: Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/85251?usp=email )
Change subject: soc/amd/common/psp/rpmc: fix printk format string
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85251/comment/44a6aba9_3e1602d9?usp... :
PS3, Line 13: The other option would have been to keep using size_t for the
: for loop counter, but using '%zu'
Why would it seem odd? I somewhat prefer the size_t and there a quite a number of other instances o […]
hm, good question why i found that odd. changed the patch to use size_t and %zu
https://review.coreboot.org/c/coreboot/+/85251/comment/887ca957_ad161f53?usp... :
PS3, Line 14: sting
nit "string"
removed that part of the commit message after changing what the patch does
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85251?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32bc584abe835c9c1d732c12311881345b8f0cdf
Gerrit-Change-Number: 85251
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Mon, 02 Dec 2024 17:05:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com