Attention is currently required from: Christian Walter, Julius Werner, Krystian Hebel, Sergii Dmytruk.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69023 )
Change subject: drivers/pc80/tpm: probe for TPM family of a device
......................................................................
Patch Set 5:
(2 comments)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/69023/comment/b0753c69_ebd44e4f
PS5, Line 432: family = TPM_2;
If intf_id == 1 that means CRB interface is active which is not compatible with pc80 TIS driver. We should also check for value 0 which will be TPM2 FIFO interface compatible with this driver, otherwise return TPM_DRIVER_ERR.
https://review.coreboot.org/c/coreboot/+/69023/comment/c3b94c20_1a3e9f34
PS5, Line 458: family_str = (family == TPM_1 ? "TPM1" : "TPM2");
family_str = (family == TPM_1 ? "TPM 1.2" : "TPM 2.0");
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5464771836c66bcc441efb7189ded416b8f53827
Gerrit-Change-Number: 69023
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 12:20:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment