Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM
......................................................................
Patch Set 18:
(4 comments)
Patchset:
PS18:
Resolving these as the changes have been made. Feel free to comment on the updated approaches if needed.
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/bef44188_49a94090
PS17, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; }
In patchset 18
Done
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/55168402_aa6dbc42
PS12, Line 179: min_pci_d_states
Implemented in patch set #15
Done
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/156ce4c7_daa1d8ff
PS13, Line 116: typedef enum {
: D0, /* 0 */
: D1, /* 1 */
: D2, /* 2 */
: D3, /* 3 */
: UNDEF
: } D_STATES;
I didn't ultimately use it as it also it doesn't seem safe as it also has unsupported values (ACPI_D […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63969
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437
Gerrit-Change-Number: 63969
Gerrit-PatchSet: 18
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 04 May 2022 16:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment