23 Jan
2020
23 Jan
'20
5:25 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26279 )
Change subject: cbfs_locate: Optionally return file type ......................................................................
Patch Set 3:
This is overloading semantics for reasons unclear. If you want to find a file's type we should have just added a function that provides the semantic. Moreover, I'm not sure this is even needed at all as it seems unused?
--
To view, visit https://review.coreboot.org/c/coreboot/+/26279
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1349d358c3054207ccbccf3825db56784327ad0
Gerrit-Change-Number: 26279
Gerrit-PatchSet: 3
Gerrit-Owner: ron minnich rminnich@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Thu, 23 Jan 2020 16:25:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment