Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35902 )
Change subject: soc/intel/apl,skl,cnl,icl: implement a PRMRR size selection algorithm
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35902/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35902/4//COMMIT_MSG@18
PS4, Line 18: withing
within
Done
https://review.coreboot.org/c/coreboot/+/35902/4//COMMIT_MSG@23
PS4, Line 23: was
is
Done
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/cannonlake/me...
File src/soc/intel/cannonlake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/cannonlake/me...
PS4, Line 60: *
Please add spaces around the operator.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a773362f8d09c8a33ff0dfac357edc6ea3564e0
Gerrit-Change-Number: 35902
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Oct 2019 10:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment