Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )
Change subject: google/kukui: Elaborate panel support for Kukui family boards.
......................................................................
Patch Set 17:
Do we expect that Kukui and Krane will always use a 100% distinct set of panels
I had some quick discussion with HW teams before and they tend to believe there'll be almost no overlap. So the plan is to have panels defined in each board-specific C file, not adding another layer of panel-specific config.
If so, maybe we want to compile all the actual panel info unconditionally and only put the <board>_panel_info arrays into the panel_<board>.c file (so the linker GC will drop unreferenced panel info structs).
We feel that's not going to be the case, but can be revised anytime if that seems more reasonable in future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19213aee1ac0f69f42e73be9e5ab72394f412a01
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 17
Gerrit-Owner: Kaka Ni
nigang@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jerry Han
hanxu5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Kaka Ni
nigang@huaqin.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Jun 2019 01:48:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment