Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33739 )
Change subject: soc/intel/icelake: Add option to enable display over PCI external GFX ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33739/9/src/soc/intel/icelake/Kconf... File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/c/coreboot/+/33739/9/src/soc/intel/icelake/Kconf... PS9, Line 211: config HAVE_EXT_GFX
- The Kconfig is poorly named. […]
1) Its a kconfig and it selects bunch of required kconfig to load/launch/execute OpRom code if mainboard selects that.
For example on Nvidia Optimus enabled laptops, that do not support hybrid graphics, the Intel GPU is always connected to the panel. It has an ext gfx, but it's never used as primary VGA device.
This is platform policy that OEM decides, i'm not OEM so i'm not making any policy here. I'm just adding my options to launch oprom if mb selects so.
2) This is not any valid point, we have proper protection in CB code and FSP to run opRom. its not a new things. Many such device has oprom and BIOS has to launch that. SOC/platform owner has to take protection before launching OpRom thats been cover already 3) its a choice for mainboard to select external GFX over internal gfx. 4) i wish to enable external GFX support for my ICL RVP hence added this config. its in SoC, so it doesn't create problem for other