[coreboot-gerrit] [M] Change in coreboot[main]: soc/amd: factor out non-CAR romstage to common code

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.

Hello Fred Reitberger, Jason Glenesk, Matt DeVillier,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/80083?usp=email

to look at the new patch set (#2).

Change subject: soc/amd: factor out non-CAR romstage to common code
......................................................................

soc/amd: factor out non-CAR romstage to common code

Since the romstage code is very similar between all AMD non-CAR SoCs,
factor out a common romstage implementation. All SoCs that select
SOC_AMD_COMMON_BLOCK_PM_CHIPSET_STATE_SAVE call fill_chipset_state, so
this Kconfig option can be used to determine whether to make that call.
In the FSP case, fsp_m_call gets called, while in the case of an
implementation that doesn't rely on an FSP to do the initialization,
cbmem_initialize_empty gets called to set up CBMEM which otherwise would
be done inside the FSP driver code. Since only some SoCs call
fch_disable_legacy_dma_io again in romstage right after fsp_m_call,
introduce the new SOC_AMD_COMMON_ROMSTAGE_LEGACY_DMA_FIXUP Kconfig
option, so that the SoCs can specify if this call is needed or not.

Signed-off-by: Felix Held 
Change-Id: I4a0695714ba08b13a58b12a490da50cb7f5a1ca9
---
M src/soc/amd/cezanne/Kconfig
M src/soc/amd/cezanne/Makefile.inc
D src/soc/amd/cezanne/romstage.c
M src/soc/amd/common/block/acpimmio/Kconfig
M src/soc/amd/common/block/cpu/noncar/Makefile.inc
A src/soc/amd/common/block/cpu/noncar/romstage.c
M src/soc/amd/genoa_poc/Makefile.inc
D src/soc/amd/genoa_poc/romstage.c
M src/soc/amd/glinda/Kconfig
M src/soc/amd/glinda/Makefile.inc
D src/soc/amd/glinda/romstage.c
M src/soc/amd/mendocino/Kconfig
M src/soc/amd/mendocino/Makefile.inc
D src/soc/amd/mendocino/romstage.c
M src/soc/amd/phoenix/Kconfig
M src/soc/amd/phoenix/Makefile.inc
D src/soc/amd/phoenix/romstage.c
M src/soc/amd/picasso/Makefile.inc
D src/soc/amd/picasso/romstage.c
19 files changed, 50 insertions(+), 165 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/80083/2