Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69815 )
Change subject: src/mainboard: Remove unnecessary space after casts ......................................................................
src/mainboard: Remove unnecessary space after casts
Change-Id: Id8e1a52279e6a606441eefe30e24bcd44e006aad Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/mainboard/51nb/x210/romstage.c M src/mainboard/acer/aspire_vn7_572g/ec.c M src/mainboard/acer/aspire_vn7_572g/mainboard.c M src/mainboard/acer/aspire_vn7_572g/romstage.c M src/mainboard/emulation/qemu-armv7/mainboard.c M src/mainboard/emulation/qemu-i440fx/memmap.c M src/mainboard/emulation/qemu-power8/uart.c M src/mainboard/emulation/qemu-riscv/uart.c M src/mainboard/emulation/spike-riscv/uart.c M src/mainboard/getac/p470/acpi_tables.c M src/mainboard/google/brya/variants/moli/ramstage.c M src/mainboard/google/storm/cdp.c M src/mainboard/ocp/deltalake/ipmi.c M src/mainboard/ocp/deltalake/romstage.c M src/mainboard/ocp/tiogapass/romstage.c M src/mainboard/pcengines/apu2/irq_tables.c M src/mainboard/protectli/vault_bsw/romstage.c M src/mainboard/purism/librem_skl/romstage.c M src/mainboard/scaleway/tagada/bmcinfo.c M src/mainboard/siemens/mc_apl1/mainboard.c M src/mainboard/siemens/mc_ehl/mainboard.c 21 files changed, 44 insertions(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/69815/1
diff --git a/src/mainboard/51nb/x210/romstage.c b/src/mainboard/51nb/x210/romstage.c index 8a8fa4f..4a776ad 100644 --- a/src/mainboard/51nb/x210/romstage.c +++ b/src/mainboard/51nb/x210/romstage.c @@ -38,6 +38,6 @@ mem_cfg->DqPinsInterleaved = TRUE; mem_cfg->CaVrefConfig = 2; mem_cfg->MemorySpdDataLen = blk.len; - mem_cfg->MemorySpdPtr00 = (uintptr_t) blk.spd_array[0]; - mem_cfg->MemorySpdPtr10 = (uintptr_t) blk.spd_array[1]; + mem_cfg->MemorySpdPtr00 = (uintptr_t)blk.spd_array[0]; + mem_cfg->MemorySpdPtr10 = (uintptr_t)blk.spd_array[1]; } diff --git a/src/mainboard/acer/aspire_vn7_572g/ec.c b/src/mainboard/acer/aspire_vn7_572g/ec.c index 570e282..72f2768 100644 --- a/src/mainboard/acer/aspire_vn7_572g/ec.c +++ b/src/mainboard/acer/aspire_vn7_572g/ec.c @@ -53,15 +53,15 @@
uint8_t ec_idx_read(uint16_t addr) { - outb((uint8_t) (addr >> 8), EC_INDEX_IO_HIGH_ADDR_PORT); - outb((uint8_t) addr, EC_INDEX_IO_LOW_ADDR_PORT); + outb((uint8_t)(addr >> 8), EC_INDEX_IO_HIGH_ADDR_PORT); + outb((uint8_t)addr, EC_INDEX_IO_LOW_ADDR_PORT); return inb(EC_INDEX_IO_DATA_PORT); }
void ec_idx_write(uint16_t addr, uint8_t data) { - outb((uint8_t) (addr >> 8), EC_INDEX_IO_HIGH_ADDR_PORT); - outb((uint8_t) addr, EC_INDEX_IO_LOW_ADDR_PORT); + outb((uint8_t)(addr >> 8), EC_INDEX_IO_HIGH_ADDR_PORT); + outb((uint8_t)addr, EC_INDEX_IO_LOW_ADDR_PORT); outb(data, EC_INDEX_IO_DATA_PORT); }
diff --git a/src/mainboard/acer/aspire_vn7_572g/mainboard.c b/src/mainboard/acer/aspire_vn7_572g/mainboard.c index eba9e98..2f222dc 100644 --- a/src/mainboard/acer/aspire_vn7_572g/mainboard.c +++ b/src/mainboard/acer/aspire_vn7_572g/mainboard.c @@ -81,7 +81,7 @@ send_ec_command(0xE0); for (int i = 0; i < 4; i++) { /* Shift bytes */ - ec_time_byte = (uint8_t) (ec_time >> (i * 8)); + ec_time_byte = (uint8_t)(ec_time >> (i * 8)); printk(BIOS_DEBUG, "EC: Sending 0x%x (iteration %d)\n", ec_time_byte, i); send_ec_data(ec_time_byte); } diff --git a/src/mainboard/acer/aspire_vn7_572g/romstage.c b/src/mainboard/acer/aspire_vn7_572g/romstage.c index 74e1438..1b5e250 100644 --- a/src/mainboard/acer/aspire_vn7_572g/romstage.c +++ b/src/mainboard/acer/aspire_vn7_572g/romstage.c @@ -30,8 +30,8 @@ mem_cfg->CaVrefConfig = 2; mem_cfg->DqPinsInterleaved = 1; mem_cfg->MemorySpdDataLen = blk.len; - mem_cfg->MemorySpdPtr00 = (uintptr_t) blk.spd_array[0]; - mem_cfg->MemorySpdPtr10 = (uintptr_t) blk.spd_array[1]; + mem_cfg->MemorySpdPtr00 = (uintptr_t)blk.spd_array[0]; + mem_cfg->MemorySpdPtr10 = (uintptr_t)blk.spd_array[1];
mem_cfg->PchSataHsioRxGen3EqBoostMagEnable[1] = 1; mem_cfg->PchSataHsioRxGen3EqBoostMag[1] = 1; diff --git a/src/mainboard/emulation/qemu-armv7/mainboard.c b/src/mainboard/emulation/qemu-armv7/mainboard.c index 441086f..a5e9183 100644 --- a/src/mainboard/emulation/qemu-armv7/mainboard.c +++ b/src/mainboard/emulation/qemu-armv7/mainboard.c @@ -15,7 +15,7 @@ /* height is at most 1024 */ int width = 800, height = 600; uint32_t framebuffer = 0x4c000000; - pl111 = (uint32_t *) 0x10020000; + pl111 = (uint32_t *)0x10020000; write32(pl111, (width / 4) - 4); write32(pl111 + 1, height - 1); /* registers 2, 3 and 5 are ignored by qemu. Set them correctly if diff --git a/src/mainboard/emulation/qemu-i440fx/memmap.c b/src/mainboard/emulation/qemu-i440fx/memmap.c index efe83c3..be730b7 100644 --- a/src/mainboard/emulation/qemu-i440fx/memmap.c +++ b/src/mainboard/emulation/qemu-i440fx/memmap.c @@ -22,11 +22,11 @@ { unsigned long high; outb(HIGH_HIGHRAM_ADDR, CMOS_ADDR_PORT); - high = ((unsigned long) inb(CMOS_DATA_PORT)) << 22; + high = ((unsigned long)inb(CMOS_DATA_PORT)) << 22; outb(MID_HIGHRAM_ADDR, CMOS_ADDR_PORT); - high |= ((unsigned long) inb(CMOS_DATA_PORT)) << 14; + high |= ((unsigned long)inb(CMOS_DATA_PORT)) << 14; outb(LOW_HIGHRAM_ADDR, CMOS_ADDR_PORT); - high |= ((unsigned long) inb(CMOS_DATA_PORT)) << 6; + high |= ((unsigned long)inb(CMOS_DATA_PORT)) << 6; return high; }
@@ -34,9 +34,9 @@ { unsigned long tomk; outb(HIGH_RAM_ADDR, CMOS_ADDR_PORT); - tomk = ((unsigned long) inb(CMOS_DATA_PORT)) << 14; + tomk = ((unsigned long)inb(CMOS_DATA_PORT)) << 14; outb(LOW_RAM_ADDR, CMOS_ADDR_PORT); - tomk |= ((unsigned long) inb(CMOS_DATA_PORT)) << 6; + tomk |= ((unsigned long)inb(CMOS_DATA_PORT)) << 6; tomk += 16 * 1024; return tomk; } diff --git a/src/mainboard/emulation/qemu-power8/uart.c b/src/mainboard/emulation/qemu-power8/uart.c index a369e62..c9113b4 100644 --- a/src/mainboard/emulation/qemu-power8/uart.c +++ b/src/mainboard/emulation/qemu-power8/uart.c @@ -7,7 +7,7 @@ static uint8_t *buf = (void *)0; uintptr_t uart_platform_base(unsigned int idx) { - return (uintptr_t) buf; + return (uintptr_t)buf; }
void uart_init(unsigned int idx) diff --git a/src/mainboard/emulation/qemu-riscv/uart.c b/src/mainboard/emulation/qemu-riscv/uart.c index 19a2b00..8f8a3a3 100644 --- a/src/mainboard/emulation/qemu-riscv/uart.c +++ b/src/mainboard/emulation/qemu-riscv/uart.c @@ -6,5 +6,5 @@
uintptr_t uart_platform_base(unsigned int idx) { - return (uintptr_t) QEMU_VIRT_UART0; + return (uintptr_t)QEMU_VIRT_UART0; } diff --git a/src/mainboard/emulation/spike-riscv/uart.c b/src/mainboard/emulation/spike-riscv/uart.c index efefc52..4ea2466 100644 --- a/src/mainboard/emulation/spike-riscv/uart.c +++ b/src/mainboard/emulation/spike-riscv/uart.c @@ -5,5 +5,5 @@
uintptr_t uart_platform_base(unsigned int idx) { - return (uintptr_t) 0x02100000; + return (uintptr_t)0x02100000; } diff --git a/src/mainboard/getac/p470/acpi_tables.c b/src/mainboard/getac/p470/acpi_tables.c index 2de388a..1429b59 100644 --- a/src/mainboard/getac/p470/acpi_tables.c +++ b/src/mainboard/getac/p470/acpi_tables.c @@ -17,7 +17,7 @@
acpi_header_t *header = &(ecdt->header);
- memset((void *) ecdt, 0, ecdt_len); + memset((void *)ecdt, 0, ecdt_len);
/* fill out header fields */ memcpy(header->signature, "ECDT", 4); @@ -48,7 +48,7 @@ memcpy(ecdt->ec_id, ec_id, sizeof(ec_id));
header->checksum = - acpi_checksum((void *) ecdt, ecdt_len); + acpi_checksum((void *)ecdt, ecdt_len);
return header->length; } diff --git a/src/mainboard/google/brya/variants/moli/ramstage.c b/src/mainboard/google/brya/variants/moli/ramstage.c index 89ccf6b..2be75e4 100644 --- a/src/mainboard/google/brya/variants/moli/ramstage.c +++ b/src/mainboard/google/brya/variants/moli/ramstage.c @@ -23,7 +23,7 @@ if (board_ver <= 1) return;
- config->enable_gpio = (struct acpi_gpio) ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A21); + config->enable_gpio = (struct acpi_gpio)ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A21); }
const struct cpu_power_limits limits[] = { diff --git a/src/mainboard/google/storm/cdp.c b/src/mainboard/google/storm/cdp.c index 39afc1a..9dd184e 100644 --- a/src/mainboard/google/storm/cdp.c +++ b/src/mainboard/google/storm/cdp.c @@ -49,7 +49,7 @@ if (board_id() != BOARD_ID_PROTO_0_2_NAND) return;
- ebi2_regs = (struct ebi2cr_regs *) EBI2CR_BASE; + ebi2_regs = (struct ebi2cr_regs *)EBI2CR_BASE;
nand_clock_config(); configure_nand_gpio(); diff --git a/src/mainboard/ocp/deltalake/ipmi.c b/src/mainboard/ocp/deltalake/ipmi.c index 1e553c0..c3ba354 100644 --- a/src/mainboard/ocp/deltalake/ipmi.c +++ b/src/mainboard/ocp/deltalake/ipmi.c @@ -20,7 +20,7 @@ struct ipmi_config_rsp rsp;
ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, - IPMI_OEM_GET_PCIE_CONFIG, NULL, 0, (unsigned char *) &rsp, + IPMI_OEM_GET_PCIE_CONFIG, NULL, 0, (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) { @@ -46,7 +46,7 @@ struct ipmi_config_rsp rsp;
ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, IPMI_OEM_GET_BOARD_ID, - NULL, 0, (unsigned char *) &rsp, sizeof(rsp)); + NULL, 0, (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) { printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n", diff --git a/src/mainboard/ocp/deltalake/romstage.c b/src/mainboard/ocp/deltalake/romstage.c index 23bbffe..d20c54c 100644 --- a/src/mainboard/ocp/deltalake/romstage.c +++ b/src/mainboard/ocp/deltalake/romstage.c @@ -105,7 +105,7 @@ }
/* Select DDR Frequency Limit */ - if (vpd_get_int(FSP_DIMM_FREQ, VPD_RW_THEN_RO, (int *const) &val_int)) { + if (vpd_get_int(FSP_DIMM_FREQ, VPD_RW_THEN_RO, (int *const)&val_int)) { printk(BIOS_INFO, "Setting DdrFreqLimit %d from VPD\n", val_int); mupd->FspmConfig.DdrFreqLimit = ddr_freq_limit(val_int); } else { diff --git a/src/mainboard/ocp/tiogapass/romstage.c b/src/mainboard/ocp/tiogapass/romstage.c index 842e977..a188ab1 100644 --- a/src/mainboard/ocp/tiogapass/romstage.c +++ b/src/mainboard/ocp/tiogapass/romstage.c @@ -32,17 +32,17 @@ { memcpy(iio_table_buf, tp_iio_bifur_table, sizeof(tp_iio_bifur_table)); mupd->FspmConfig.IioBifurcationConfig.IIoBifurcationTable = - (UPD_IIO_BIFURCATION_DATA_ENTRY *) iio_table_buf; + (UPD_IIO_BIFURCATION_DATA_ENTRY *)iio_table_buf; mupd->FspmConfig.IioBifurcationConfig.NumberOfEntries = ARRAY_SIZE(tp_iio_bifur_table);
mupd->FspmConfig.IioPciConfig.ConfigurationTable = - (UPD_PCI_PORT_CONFIG *) tp_iio_pci_port_skt0; + (UPD_PCI_PORT_CONFIG *)tp_iio_pci_port_skt0; mupd->FspmConfig.IioPciConfig.NumberOfEntries = ARRAY_SIZE(tp_iio_pci_port_skt0);
mupd->FspmConfig.PchPciConfig.PciPortConfig = - (UPD_PCH_PCIE_PORT *) tp_pch_pci_port_skt0; + (UPD_PCH_PCIE_PORT *)tp_pch_pci_port_skt0; mupd->FspmConfig.PchPciConfig.NumberOfEntries = ARRAY_SIZE(tp_pch_pci_port_skt0);
diff --git a/src/mainboard/pcengines/apu2/irq_tables.c b/src/mainboard/pcengines/apu2/irq_tables.c index fcd4772..4d56145 100644 --- a/src/mainboard/pcengines/apu2/irq_tables.c +++ b/src/mainboard/pcengines/apu2/irq_tables.c @@ -43,7 +43,7 @@ printk(BIOS_INFO, "Writing IRQ routing tables to 0x%lx...", addr);
pirq = (void *)(addr); - v = (u8 *) (addr); + v = (u8 *)(addr);
pirq->signature = PIRQ_SIGNATURE; pirq->version = PIRQ_VERSION; diff --git a/src/mainboard/protectli/vault_bsw/romstage.c b/src/mainboard/protectli/vault_bsw/romstage.c index 33519b9..745cb82 100644 --- a/src/mainboard/protectli/vault_bsw/romstage.c +++ b/src/mainboard/protectli/vault_bsw/romstage.c @@ -15,7 +15,7 @@ * FSP enables internal UART. Disable it and re-enable Super I/O UART to * prevent loss of debug information on serial. */ - pci_write_config32(PCI_DEV(0, LPC_DEV, 0), UART_CONT, (u32) 0); + pci_write_config32(PCI_DEV(0, LPC_DEV, 0), UART_CONT, (u32)0); ite_enable_serial(SERIAL1_DEV, CONFIG_TTYS0_BASE); }
diff --git a/src/mainboard/purism/librem_skl/romstage.c b/src/mainboard/purism/librem_skl/romstage.c index 604db60..2b35fc2 100644 --- a/src/mainboard/purism/librem_skl/romstage.c +++ b/src/mainboard/purism/librem_skl/romstage.c @@ -31,7 +31,7 @@ mem_cfg->DqPinsInterleaved = TRUE; mem_cfg->CaVrefConfig = 2; mem_cfg->MemorySpdDataLen = blk.len; - mem_cfg->MemorySpdPtr00 = (uintptr_t) blk.spd_array[0]; + mem_cfg->MemorySpdPtr00 = (uintptr_t)blk.spd_array[0];
/* Enable and set SATA HSIO adjustments for ports 0 and 2 */ mem_cfg->PchSataHsioRxGen3EqBoostMagEnable[0] = 1; diff --git a/src/mainboard/scaleway/tagada/bmcinfo.c b/src/mainboard/scaleway/tagada/bmcinfo.c index e015837..2de2f2e 100644 --- a/src/mainboard/scaleway/tagada/bmcinfo.c +++ b/src/mainboard/scaleway/tagada/bmcinfo.c @@ -94,7 +94,7 @@ char *bmcinfo_serial(void) { if (IS_BMC_INFO_FIELD_VALID(bmcSerial)) - return (char *) BMC_INFO->bmcSerial; + return (char *)BMC_INFO->bmcSerial; return NULL; }
diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c index dc188b3..0593797 100644 --- a/src/mainboard/siemens/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/mainboard.c @@ -264,7 +264,7 @@ return;
/* Get legacy delay parameter from hwinfo. */ - if (hwilib_get_field(LegacyDelay, (uint8_t *) &legacy_delay, + if (hwilib_get_field(LegacyDelay, (uint8_t *)&legacy_delay, sizeof(legacy_delay)) != sizeof(legacy_delay)) return;
diff --git a/src/mainboard/siemens/mc_ehl/mainboard.c b/src/mainboard/siemens/mc_ehl/mainboard.c index 9436244..7aa0d86 100644 --- a/src/mainboard/siemens/mc_ehl/mainboard.c +++ b/src/mainboard/siemens/mc_ehl/mainboard.c @@ -100,7 +100,7 @@ return;
/* Get legacy delay parameter from hwinfo. */ - if (hwilib_get_field(LegacyDelay, (uint8_t *) &legacy_delay, + if (hwilib_get_field(LegacyDelay, (uint8_t *)&legacy_delay, sizeof(legacy_delay)) != sizeof(legacy_delay)) return;