Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )
Change subject: soc/amd/picasso: Add northbridge pci driver ......................................................................
Patch Set 26:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34424/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34424/26//COMMIT_MSG@12 PS26, Line 12: I thought same parent commit wrote, there isn’t a northbridge.
https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... File src/soc/amd/picasso/northbridge.c:
https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... PS26, Line 18: int idx = 0x10; unsigned
https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... PS26, Line 32: ram_resource(dev, idx++, 1 * MiB / KiB, (mem_usable - 1 * MiB) / KiB); MiB / KiB = KiB?
https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... PS26, Line 88: .acpi_fill_ssdt = northbridge_fill_ssdt_generator, Please use tabs as in the first line.
https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... PS26, Line 94: .device = PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB, Ditto.