Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40951 )
Change subject: soc/amd/common/block/lpc: Add lpc_disable_spi_rom_sharing ......................................................................
Uploaded patch set 2.
(2 comments)
https://review.coreboot.org/c/coreboot/+/40951/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/40951/1/src/soc/amd/common/block/lp... PS1, Line 306: u8 byte;
I think I'd prefer this: […]
Cool. Didn't know about that.
https://review.coreboot.org/c/coreboot/+/40951/1/src/soc/amd/common/block/lp... PS1, Line 311: pci_write_config8(_LPCB_DEV, LPC_PCI_CONTROL, byte);
Can `pci_update_config8()` be used?
It could, though I don't think it's any easier to read.
pci_update_config8(_LPCB_DEV, LPC_PCI_CONTROL, ~(VW_ROM_SHARING_EN | EXT_ROM_SHARING_EN), 0);