[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Configure SPI CS parameters in FSP UPD.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32791 )

Change subject: soc/intel/cannonlake: Configure SPI CS parameters in FSP UPD.
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/32791/5/src/soc/intel/cannonlake/fsp_params.... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/32791/5/src/soc/intel/cannonlake/fsp_params.... 
PS5, Line 137: 			/* GSPI driver assumes CS0 is used */
> Is this why we're only passing index 0 for the CsEnable and CsOutput? If so, please add a comment be […]

Yes, will do.

https://review.coreboot.org/#/c/32791/5/src/soc/intel/cannonlake/fsp_params.... 
PS5, Line 403: (
> fwiw, the parens aren't needed

True, I just know that sometimes I forget the precedence and that keeps things clear.  If it's confusing, I'll remove them.