Hello Rajat Jain, Duncan Laurie, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36041
to look at the new patch set (#7).
Change subject: drivers/gfx: Add generic graphics with SSDT generator ......................................................................
drivers/gfx: Add generic graphics with SSDT generator
This change adds a generic graphics driver that can be added to a devicetree which populates graphics related ACPI table. It will write the _DOD method (Enumerate All Devices Attached to the Display Adapter) and a device object for each device defined. The device may optionally have a connected privacy screen which can be controlled with a _DSM.
Example: chip drivers/generic/gfx register "device_count" = "1" register "device[0].name" = ""LCD"" register "device[0].addr" = "0x0400" register "device[0].privacy.enabled" = "1" register "device[0].privacy.detect_function" = ""\_SB.PCI0.PVSC.GPVD"" register "device[0].privacy.status_function" = ""\_SB.PCI0.PVSC.GPVX"" register "device[0].privacy.enable_function" = ""\_SB.PCI0.PVSC.EPVX"" register "device[0].privacy.disable_function" = ""\_SB.PCI0.PVSC.DPVX"" device generic 0 on end end
ASL Scope (_SB.PCI0.GFX0) { Method (_DOD, 0, NotSerialized) // _DOD: Display Output Devices { Return (Package (0x01) { 0x00000400 }) }
Device (LCD) { Name (_ADR, 0x0400) // _ADR: Address Name (_STA, 0x0F) // _STA: Status Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method { ToBuffer (Arg0, Local0) If ((Local0 == ToUUID ("c7033113-8720-4ceb-9090-9d52b3e52d73"))) { ToInteger (Arg2, Local1) If ((Local1 == Zero)) { Local2 = _SB.PCI0.PVSC.GPVD () If ((Local2 == One)) { Return (Buffer (One) { 0x0F }) } }
If ((Local1 == One)) { ToBuffer (_SB.PCI0.PVSC.GPVX (), Local2) Return (Local2) }
If ((Local1 == 0x02)) { _SB.PCI0.PVSC.EPVX () }
If ((Local1 == 0x03)) { _SB.PCI0.PVSC.DPVX () }
Return (Buffer (One) { 0x00 }) }
Return (Buffer (One) { 0x00 }) } } }
BUG=b:142237145 TEST=Added gfx to devicetree on sarien_cml and correct ASL in SSDT
Change-Id: Ida520dd7aad81ee7c1e5f2d0d3f5cc1a766d78a0 Signed-off-by: Mathew King mathewk@chromium.org --- A src/drivers/generic/gfx/Kconfig A src/drivers/generic/gfx/Makefile.inc A src/drivers/generic/gfx/chip.h A src/drivers/generic/gfx/gfx.c 4 files changed, 172 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/36041/7