Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@27 PS3, Line 27: - Mainboard serial number is invalid
does the mainboard have at24rf80 i2c eeprom? […]
I don't know. And not all the EEPROM in the thinkpads are at24rf80. I think the serial number is still stored in some chip.
https://review.coreboot.org/c/coreboot/+/34359/3/Documentation/mainboard/len... File Documentation/mainboard/lenovo/t440p.md:
https://review.coreboot.org/c/coreboot/+/34359/3/Documentation/mainboard/len... PS3, Line 32: Please see :doc:`../../northbridge/intel/haswell/mrc.bin`.
no need for rst. The lastest sphinx can interpret markdown that has .. […]
I see other docs using this. I think rst is for :doc:?