Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35727 )
Change subject: intel/pci_devs: Regroup PCI xx_DEVID entries
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35727/2/src/soc/intel/braswell/incl...
File src/soc/intel/braswell/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35727/2/src/soc/intel/braswell/incl...
PS2, Line 156: #define SMBUS_DEVID 0x0f12
presumably we should be moving all these to src/include/device/pci_ids.h ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35727
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I953e9a7746232b4c40deca55eb6cb3bd7af91496
Gerrit-Change-Number: 35727
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 20:50:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment