Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46385 )
Change subject: HACK: mt8192: Add SPI support ......................................................................
Patch Set 1:
(2 comments)
Hi Yidi, please fix this and correct description, remove the HACK.
https://review.coreboot.org/c/coreboot/+/46385/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46385/1//COMMIT_MSG@6 PS1, Line 6: : HACK: mt8192: Add SPI support : : Missing pinctrl, so we just hardcode SPI1/SPI5 pins for now. : : TODO: There's actually 8 SPI controllers, I think : mb/google/asurada: enable SPI devices
Configure and initialize EC and TPM on Asurada.
https://review.coreboot.org/c/coreboot/+/46385/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/bootblock.c:
https://review.coreboot.org/c/coreboot/+/46385/1/src/mainboard/google/asurad... PS1, Line 10: // please uncomment this - I think we have enough drivers for enabling eint?