Attention is currently required from: Nico Huber, Raul Rangel, Furquan Shaikh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42886 )
Change subject: soc/amd/picasso: Move EARLY_RESERVED_DRAM_BASE to 0x100000
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/42886/comment/6b2b18e1_5ce5e968
PS1, Line 10: closes the ~31 MiB gap between the Option ROM and Early RAM.
Yes, that was the original intent to leave that hole before EARLY_RESERVED_DRAM_BASE.
What changed to make this unnecessary?
https://review.coreboot.org/c/coreboot/+/42886/comment/e309a264_566d0e7a
PS1, Line 21: [ 0.000000] BIOS-e820: [mem 0x000000042f340000-0x000000042fffffff] reserved
You could remove the timestamps to make the lines fit in 72 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5944abce19f17458ea3017d04f6dfdfe8e8050bf
Gerrit-Change-Number: 42886
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 18 Feb 2021 23:15:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment