Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Angel Pons, Meera Ravindranath, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60801 )
Change subject: soc/intel/common/gpio: Perform GPIO PAD lock outside SMM
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137593):
https://review.coreboot.org/c/coreboot/+/60801/comment/5b370316_000e5a5c
PS8, Line 578: printk(BIOS_INFO, "%s: Locking pad %d configuration\n", __func__, gpio_num);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71b4e2f24303b6acb56debd581bd6bc818b6f926
Gerrit-Change-Number: 60801
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 07 Jan 2022 13:57:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment