Attention is currently required from: Arthur Heymans, Furquan Shaikh, Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57049 )
Change subject: arch/x86: Implement cpu_info in C code
......................................................................
Patch Set 2:
(1 comment)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/57049/comment/100a4484_47fcb0e6
PS2, Line 237: return ALIGN_UP(&s, CONFIG_STACK_SIZE) - sizeof(struct cpu_info);
Oh C's type system....
this compiles:
```
char s;
uintptr_t stack = (uintptr_t)&s;
uintptr_t cpu_info = ALIGN_UP(stack, CONFIG_STACK_SIZE) - sizeof(struct cpu_info);
return (struct cpu_info *)cpu_info;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57049
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7396b8429e29739e18a189dacea3a76e571cd58
Gerrit-Change-Number: 57049
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 25 Aug 2021 14:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment