Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36125 )
Change subject: mb/google/hatch/var/dratini: Add ELAN touchscreen support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36125/2/src/mainboard/google/hatch/...
PS2, Line 123: 130
What is this delay? I don't see it in the datasheet.
in datasheet, from reset to i2c activity need to 300ms.
I feel 300 ms is too long. So, I add stop pin delay to 130 ms and make sure the sequence can
meet elan's FW requirement with elan fw engineer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36125
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ebc067bbb407498de00ea0b6c23b0848023cffe
Gerrit-Change-Number: 36125
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sun, 20 Oct 2019 04:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment